Future-proof against some upcoming fetcher changes.#237
Closed
mwyman wants to merge 5 commits intogoogle:mainfrom
Closed
Future-proof against some upcoming fetcher changes.#237mwyman wants to merge 5 commits intogoogle:mainfrom
mwyman wants to merge 5 commits intogoogle:mainfrom
Conversation
petea
reviewed
Oct 11, 2022
…th explicit implementations. This future-proofs against fetcher changes.
mwyman
changed the title
alaoy0225
approved these changes
Nov 17, 2022
Contributor
|
Hi Michael! Please feel free to update the branch & re-open if this is still a desirable change :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To eliminate
dispatch_semaphoreusage, theGTMSessionFetcherServiceprotocol was changed recently; this adds the required method to ensure the tests don't break if building with the latest fetcher.